Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/renderer_host/resource_message_filter_gtk.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: a few more simplifications Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter_gtk.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter_gtk.cc (revision 30037)
+++ chrome/browser/renderer_host/resource_message_filter_gtk.cc (working copy)
@@ -54,8 +54,9 @@
WebScreenInfo results = WebScreenInfoFactory::screenInfo(display, screen);
ViewHostMsg_GetScreenInfo::WriteReplyParams(reply_msg, results);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -78,8 +79,9 @@
ViewHostMsg_GetWindowRect::WriteReplyParams(reply_msg, rect);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -117,8 +119,9 @@
ViewHostMsg_GetRootWindowRect::WriteReplyParams(reply_msg, rect);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -130,8 +133,9 @@
ViewHostMsg_ClipboardIsFormatAvailable::WriteReplyParams(reply_msg, result);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -143,8 +147,9 @@
ViewHostMsg_ClipboardReadText::WriteReplyParams(reply_msg, result);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -156,8 +161,9 @@
ViewHostMsg_ClipboardReadAsciiText::WriteReplyParams(reply_msg, result);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -171,8 +177,9 @@
ViewHostMsg_ClipboardReadHTML::WriteReplyParams(reply_msg, markup, src_url);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
@@ -203,32 +210,36 @@
ViewHostMsg_AllocateTempFileForPrinting::WriteReplyParams(
reply_msg, temp_file_fd, fd_in_browser);
- ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::SendDelayedReply, reply_msg));
}
// Called on the IO thread.
void ResourceMessageFilter::OnGetScreenInfo(gfx::NativeViewId view,
IPC::Message* reply_msg) {
- ChromeThread::GetMessageLoop(ChromeThread::BACKGROUND_X11)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::BACKGROUND_X11, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::DoOnGetScreenInfo, view, reply_msg));
}
// Called on the IO thread.
void ResourceMessageFilter::OnGetWindowRect(gfx::NativeViewId view,
IPC::Message* reply_msg) {
- ChromeThread::GetMessageLoop(ChromeThread::BACKGROUND_X11)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::BACKGROUND_X11, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::DoOnGetWindowRect, view, reply_msg));
}
// Called on the IO thread.
void ResourceMessageFilter::OnGetRootWindowRect(gfx::NativeViewId view,
IPC::Message* reply_msg) {
- ChromeThread::GetMessageLoop(ChromeThread::BACKGROUND_X11)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::BACKGROUND_X11, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::DoOnGetRootWindowRect, view,
reply_msg));
}
@@ -269,8 +280,9 @@
// Called on the IO thread.
void ResourceMessageFilter::OnAllocateTempFileForPrinting(
IPC::Message* reply_msg) {
- ChromeThread::GetMessageLoop(ChromeThread::FILE)->PostTask(
- FROM_HERE, NewRunnableMethod(
+ ChromeThread::PostTask(
+ ChromeThread::FILE, FROM_HERE,
+ NewRunnableMethod(
this, &ResourceMessageFilter::DoOnAllocateTempFileForPrinting,
reply_msg));
}

Powered by Google App Engine
This is Rietveld 408576698