chrome/browser/printing/print_job_worker.cc - Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: a few more simplifications Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/in_process_webkit/webkit_thread.cc ('K') | « chrome/browser/power_save_blocker_common.cc ('k') | chrome/browser/process_singleton_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_job_worker.cc

===================================================================

--- chrome/browser/printing/print_job_worker.cc (revision 30037)

+++ chrome/browser/printing/print_job_worker.cc (working copy)

@@ -77,10 +77,11 @@

if (ask_user_for_settings) {

#if defined(OS_MACOSX)

- ChromeThread::GetMessageLoop(ChromeThread::UI)->PostTask(

- FROM_HERE, NewRunnableMethod(this, &PrintJobWorker::GetSettingsWithUI,

- parent_window, document_page_count,

- has_selection));

+ ChromeThread::PostTask(

+ ChromeThread::UI, FROM_HERE,

+ NewRunnableMethod(this, &PrintJobWorker::GetSettingsWithUI,

+ parent_window, document_page_count,

+ has_selection));

#else

PrintingContext::Result result = printing_context_.AskUserForSettings(

parent_window, document_page_count, has_selection);

@@ -111,8 +112,7 @@

void PrintJobWorker::GetSettingsWithUI(gfx::NativeWindow parent_window,

int document_page_count,

bool has_selection) {

- DCHECK_EQ(ChromeThread::GetMessageLoop(ChromeThread::UI),

- MessageLoop::current());

+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));

PrintingContext::Result result = printing_context_.AskUserForSettings(

parent_window, document_page_count, has_selection);

« chrome/browser/in_process_webkit/webkit_thread.cc ('K') | « chrome/browser/power_save_blocker_common.cc ('k') | chrome/browser/process_singleton_linux.cc » ('j') | no next file with comments »