Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: chrome/browser/chromeos/cros_network_library.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: a few more simplifications Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_network_library.cc
===================================================================
--- chrome/browser/chromeos/cros_network_library.cc (revision 30037)
+++ chrome/browser/chromeos/cros_network_library.cc (working copy)
@@ -20,13 +20,12 @@
};
CrosNetworkLibrary::CrosNetworkLibrary() {
- if (CrosLibrary::loaded()) {
- MessageLoop* loop = ChromeThread::GetMessageLoop(ChromeThread::FILE);
- if (loop) {
- loop->PostTask(FROM_HERE, NewRunnableMethod(this,
- &CrosNetworkLibrary::InitOnBackgroundThread));
- }
- }
+ if (!CrosLibrary::loaded())
+ return;
+
+ ChromeThread::PostTask(
+ ChromeThread::FILE, FROM_HERE,
+ NewRunnableMethod(this, &CrosNetworkLibrary::InitOnBackgroundThread));
}
CrosNetworkLibrary::~CrosNetworkLibrary() {
@@ -71,15 +70,16 @@
void CrosNetworkLibrary::ConnectToWifiNetwork(WifiNetwork network,
const string16& password) {
- if (CrosLibrary::loaded()) {
- MessageLoop* loop = ChromeThread::GetMessageLoop(ChromeThread::FILE);
- if (loop)
- loop->PostTask(FROM_HERE, NewRunnableFunction(
+ if (!CrosLibrary::loaded())
+ return;
+
+ ChromeThread::PostTask(
+ ChromeThread::FILE, FROM_HERE,
+ NewRunnableFunction(
&chromeos::ConnectToWifiNetwork,
network.ssid.c_str(),
password.empty() ? NULL : UTF16ToUTF8(password).c_str(),
GetEncryptionString(network.encryption)));
- }
}
// static
@@ -139,11 +139,11 @@
const WifiNetworkVector& networks, bool ethernet_connected) {
// Make sure we run on UI thread.
if (!ChromeThread::CurrentlyOn(ChromeThread::UI)) {
- MessageLoop* loop = ChromeThread::GetMessageLoop(ChromeThread::UI);
- if (loop)
- loop->PostTask(FROM_HERE, NewRunnableMethod(this,
- &CrosNetworkLibrary::UpdateNetworkStatus, networks,
- ethernet_connected));
+ ChromeThread::PostTask(
+ ChromeThread::UI, FROM_HERE,
+ NewRunnableMethod(this,
+ &CrosNetworkLibrary::UpdateNetworkStatus, networks,
+ ethernet_connected));
return;
}

Powered by Google App Engine
This is Rietveld 408576698