chrome/browser/extensions/pack_extension_job.cc - Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: a few more simplifications Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_manager.cc ('K') | « chrome/browser/extensions/pack_extension_job.h ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.cc » ('j') | chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/pack_extension_job.cc

===================================================================

--- chrome/browser/extensions/pack_extension_job.cc (revision 30037)

+++ chrome/browser/extensions/pack_extension_job.cc (working copy)

@@ -7,16 +7,17 @@

#include "base/message_loop.h"

#include "base/string_util.h"

#include "base/task.h"

+#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/extensions/extension_creator.h"

PackExtensionJob::PackExtensionJob(Client* client,

const FilePath& root_directory,

- const FilePath& key_file,

- MessageLoop* file_loop)

- : ui_loop_(MessageLoop::current()), file_loop_(file_loop), client_(client),

+ const FilePath& key_file)

+ : ui_loop_(MessageLoop::current()), client_(client),

root_directory_(root_directory), key_file_(key_file) {

- file_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,

- &PackExtensionJob::RunOnFileThread));

+ ChromeThread::PostTask(

+ ChromeThread::FILE, FROM_HERE,

+ NewRunnableMethod(this, &PackExtensionJob::RunOnFileThread));

}

void PackExtensionJob::ClearClient() {

Property changes on: chrome\browser\extensions\pack_extension_job.cc

___________________________________________________________________

Added: svn:eol-style

+ LF