chrome/browser/extensions/extension_message_service.cc - Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_service.cc

Issue 306032: Simplify threading in browser thread by making only ChromeThread deal with di... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: a few more simplifications Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_manager.cc ('K') | « chrome/browser/extensions/extension_disabled_infobar_delegate.cc ('k') | chrome/browser/extensions/extension_updater_unittest.cc » ('j') | chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_service.cc

===================================================================

--- chrome/browser/extensions/extension_message_service.cc (revision 30037)

+++ chrome/browser/extensions/extension_message_service.cc (working copy)

@@ -198,8 +198,7 @@

int routing_id, const std::string& source_extension_id,

const std::string& target_extension_id,

const std::string& channel_name, ResourceMessageFilter* source) {

- DCHECK_EQ(MessageLoop::current(),

- ChromeThread::GetMessageLoop(ChromeThread::IO));

+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));

// Create a channel ID for both sides of the channel.

int port1_id = -1;

@@ -222,8 +221,7 @@

const std::string& extension_id,

const std::string& channel_name,

ResourceMessageFilter* source) {

- DCHECK_EQ(MessageLoop::current(),

- ChromeThread::GetMessageLoop(ChromeThread::IO));

+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));

// Create a channel ID for both sides of the channel.

int port1_id = -1;