Simplify threading in browser thread by making only ChromeThread deal with di...

chrome/browser/download/download_manager.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active profile in Chrome.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
@@ skipping 331 matching lines @@
   bool Init(Profile* profile);
 
   // Schedule a query of the history service to retrieve all downloads.
   void QueryHistoryForDownloads();
 
   // Notifications sent from the download thread to the UI thread
   void StartDownload(DownloadCreateInfo* info);
   void UpdateDownload(int32 download_id, int64 size);
   void DownloadFinished(int32 download_id, int64 size);
 
-  // Helper method for cancelling the network request associated with a
-  // download.
-  static void CancelDownloadRequest(int render_process_id, int request_id);
-
-  // Called from a view when a user clicks a UI button or link.
+ // Called from a view when a user clicks a UI button or link.
   void DownloadCancelled(int32 download_id);
   void PauseDownload(int32 download_id, bool pause);
   void RemoveDownload(int64 download_handle);
 
   // Called when the download is renamed to its final name.
   void DownloadRenamedToFinalName(int download_id, const FilePath& full_path);
 
   // Remove downloads after remove_begin (inclusive) and before remove_end
   // (exclusive). You may pass in null Time values to do an unbounded delete
   // in either direction.
@@ skipping 87 matching lines @@
   // Used to make sure we have a safe file extension and filename for a
   // download.  |file_name| can either be just the file name or it can be a
   // full path to a file.
   void GenerateSafeFilename(const std::string& mime_type,
                             FilePath* file_name);
 
   // Used to determine whether the download item is an extension file or not.
   static bool IsExtensionInstall(const DownloadItem* item);
   static bool IsExtensionInstall(const DownloadCreateInfo* info);
 
+  // Runs the network cancel.  Must be called on the IO thread.
+  static void OnCancelDownloadRequest(ResourceDispatcherHost* rdh,
+                                      int render_process_id,
+                                      int request_id);
+
  private:
   // Opens a download via the Windows shell.
   void OpenDownloadInShell(const DownloadItem* download,
                            gfx::NativeView parent_window);
 
   // Opens downloaded Chrome extension file (*.crx).
   void OpenChromeExtension(const FilePath& full_path, const GURL& download_url,
                            const GURL& referrer_url);
 
   // Shutdown the download manager.  This call is needed only after Init.
@@ skipping 29 matching lines @@
   void GenerateFilename(DownloadCreateInfo* info, FilePath* generated_name);
 
   // Persist the automatic opening preference.
   void SaveAutoOpens();
 
   // Download cancel helper function.
   void DownloadCancelledInternal(int download_id,
                                  int render_process_id,
                                  int request_id);
 
-  // Runs the network cancel on the IO thread.
-  static void OnCancelDownloadRequest(ResourceDispatcherHost* rdh,
-                                      int render_process_id,
-                                      int request_id);
-
   // Runs the pause on the IO thread.
   static void OnPauseDownloadRequest(ResourceDispatcherHost* rdh,
                                      int render_process_id,
                                      int request_id,
                                      bool pause);
 
   // Performs the last steps required when a download has been completed.
   // It is necessary to break down the flow when a download is finished as
   // dangerous downloads are downloaded to temporary files that need to be
   // renamed on the file thread first.
@@ skipping 95 matching lines @@
   PendingFinishedMap pending_finished_downloads_;
 
   // The "Save As" dialog box used to ask the user where a file should be
   // saved.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_