Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 306023015: DevTools: [CodeMirror] show native copy/paste/cut items in editor context menu (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CodeMirror] show native copy/paste/cut items in editor context menu Currently, if you select some text in text editor and then do a right-click inside selection, the just-summoned context menu won't have a copy/paste/cut items, as well as other native items natural for text area context menu. This happens due to the way CodeMirror handles contextmenu event. It focuses a small text area during the contextmenu bubbling phase, so the upcoming ContextMenu gets populated with appropriate items. Unfortunately, codemirror does all this textarea mess *after* firing its own "contextmenu" event, and as we create menu in the listener, it doesn't have correct active element. This patch goes back to listening contextmenu event on element, which due to bubbling nature happens after textarea was focused. R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lushnikov
ptal!
6 years, 6 months ago (2014-06-02 13:04:48 UTC) #1
vsevik
lgtm
6 years, 6 months ago (2014-06-02 13:36:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/306023015/1
6 years, 6 months ago (2014-06-02 13:37:02 UTC) #3
commit-bot: I haz the power
Change committed as 175286
6 years, 6 months ago (2014-06-02 14:52:15 UTC) #4
pfeldman
Should we get a list of manual tests for the codemirror rolls? Sort of a ...
6 years, 6 months ago (2014-06-02 15:15:10 UTC) #5
lushnikov
On 2014/06/02 15:15:10, pfeldman_ooo wrote: > Should we get a list of manual tests for ...
6 years, 6 months ago (2014-06-02 19:19:23 UTC) #6
lushnikov
The CL that regressed this: https://codereview.chromium.org/247013004/
6 years, 6 months ago (2014-06-02 19:20:49 UTC) #7
pfeldman
6 years, 6 months ago (2014-06-03 05:53:46 UTC) #8
Message was sent while issue was closed.
> But anyhow, I already do manual testing for every CM roll. So far it doesn't
> regularly regress functionality, does it?

So far, it worked perfectly, and that is why we should capture the scenarios you
check  upon every roll. That way you are not the only one who can make a quality
roll + you don't forget all the things you check. A simple text file with a list
of things to check before roll lands is more than enough.

Powered by Google App Engine
This is Rietveld 408576698