Enable Drive integration service in incognito windows.

Enable Drive integration service in incognito windows.

BUG=359418
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275415

[kinaba, 2014-06-02 12:11:30]

@hashimoto: PTAL.

(The feature is still under privacy review so I'm planning to land this CL after
LG'ed AND approved.)

[hashimoto, 2014-06-03 06:10:32]

lgtm

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/download_handler.cc (right):

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/download_handler.cc:151: if (!notifier_incognito_)
{
nit: DCHECK(!notifier_incognito_) is enough?

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/download_handler.cc:335: manager =
notifier_incognito_->GetManager();
nit: How about adding a private method which maps void* to DownloadManager*?

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/drive_integration_service.cc (right):

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/drive_integration_service.cc:523: // Installs the
handler also to incognito profile.
nit-picking-nit: s/Installs/Install/

[kinaba, 2014-06-03 06:50:32]

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/download_handler.cc (right):

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/download_handler.cc:151: if (!notifier_incognito_)
{
On 2014/06/03 06:10:32, hashimoto wrote:
> nit: DCHECK(!notifier_incognito_) is enough?

Done.

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/download_handler.cc:335: manager =
notifier_incognito_->GetManager();
On 2014/06/03 06:10:32, hashimoto wrote:
> nit: How about adding a private method which maps void* to DownloadManager*?

Done.

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/drive_integration_service.cc (right):

https://codereview.chromium.org/306023012/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/drive_integration_service.cc:523: // Installs the
handler also to incognito profile.
On 2014/06/03 06:10:32, hashimoto wrote:
> nit-picking-nit: s/Installs/Install/

Done.

[hashimoto, 2014-06-03 07:35:27]

lgtm

[kinaba, 2014-06-06 05:19:56]

On 2014/06/02 12:11:30, kinaba wrote:
> (The feature is still under privacy review so I'm planning to land this CL
after
> LG'ed AND approved.)

Suggested to go ahead and revert later if it is decided to turn down. CQing.

[kinaba, 2014-06-06 05:20:00]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-06-06 05:22:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/306023012/40001

[commit-bot: I haz the power, 2014-06-06 11:44:06]

Change committed as 275415