Add new DialogDelegate for dialogs in the App List

chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h

Index: chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h
diff --git a/chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h b/chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..573b34713ae3ee6f29aa19eec1625ac8d7b8dcc2
--- /dev/null
+++ b/chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h
@@ -0,0 +1,60 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_APP_LIST_APP_LIST_DIALOG_APP_LIST_DIALOG_CONTENTS_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_APP_LIST_APP_LIST_DIALOG_APP_LIST_DIALOG_CONTENTS_VIEW_H_
+
+#include "chrome/browser/ui/views/app_list/app_list_dialog/app_list_dialog_contents_view.h"
+#include "ui/accessibility/ax_enums.h"

[tapted, 2014/06/11 08:35:00]

same thing with most of these: typically types that appear only in
virtual..OVERRIDE method declarations don't need their header or a forward
declare. There's a ... 4-year old thread
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/i_5qAOxe0xY/C4hJi...

[sashab, 2014/06/12 00:13:43]

Cleaned this up in all 6 files and in app_info_dialog_views.

+#include "ui/base/ui_base_types.h"
+#include "ui/gfx/native_widget_types.h"
+#include "ui/views/view.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_delegate.h"
+#include "ui/views/window/client_view.h"
+#include "ui/views/window/non_client_view.h"
+
+namespace gfx {
+class Rect;
+}
+
+// The contents view for an App List Dialog, which covers the entire app list.
+class AppListDialogContentsView : public views::WidgetDelegate,
+                                  public views::View {
+ public:
+  AppListDialogContentsView();
+  virtual ~AppListDialogContentsView();
+
+  // Create a |dialog| window Widget with the specified |context| or |parent|.
+  static views::Widget* CreateDialogWidget(AppListDialogContentsView* dialog,
+                                           gfx::NativeView parent,
+                                           gfx::Rect bounds);

[tapted, 2014/06/11 08:35:00]

nit: const-reference

[sashab, 2014/06/12 00:13:43]

Ahh yup, good find. Done.

+
+  // Called when the dialog is closed.

[tapted, 2014/06/11 08:34:59]

This probably repeats a comment from the parent. Should be // Overridden from...

[sashab, 2014/06/12 00:13:43]

Oh, I see hat WidgetDelegate has WindowClosing(). Got rid of this to use that
one instead.

+  virtual void OnClosed();
+
+  // Overridden from WidgetDelegate:
+  virtual views::View* GetInitiallyFocusedView() OVERRIDE;
+  virtual views::ClientView* CreateClientView(views::Widget* widget) OVERRIDE;
+  virtual views::NonClientFrameView* CreateNonClientFrameView(
+      views::Widget* widget) OVERRIDE;
+
+  // Overridden from places:

[tapted, 2014/06/11 08:34:59]

places? :)

[sashab, 2014/06/12 00:13:43]

Haha, whoops ^_^; fixed. I actually changed this to override WidgetDelegateView
instead and could remove a lot of these functions.

+  virtual void DeleteDelegate() OVERRIDE;
+  virtual views::Widget* GetWidget() OVERRIDE;
+  virtual const views::Widget* GetWidget() const OVERRIDE;
+  virtual views::View* GetContentsView() OVERRIDE;
+
+  virtual void WindowClosing() OVERRIDE;
+
+ protected:
+  // Overridden from WidgetDelegate:
+  virtual ui::AXRole GetAccessibleWindowRole() const OVERRIDE;
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AppListDialogContentsView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_APP_LIST_APP_LIST_DIALOG_APP_LIST_DIALOG_CONTENTS_VIEW_H_