Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate.cc

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_controller_delegate_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
index c174a07b22fed69a06a292b48076d184beff0ac0..0169d7590b9ca107535db8eac8149ad412c8d86f 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
@@ -101,27 +101,11 @@ void AppListControllerDelegate::DoShowAppInfoFlow(
extension_id);
DCHECK(extension);
- gfx::NativeWindow parent_window = GetAppListWindow();
- if (!parent_window)
- return;
-
- // For the centered app list, inset the dialog further so it appears as a
- // vertical column in the center of the app list.
- const int kAppListDialogHorizontalBorderInsets =
- app_list::switches::IsCenteredAppListEnabled() ? 110 : 10;
- const int kAppListDialogVerticalBorderInsets = 10;
-
- gfx::Rect dialog_bounds = GetAppListBounds();
- dialog_bounds.Inset(kAppListDialogHorizontalBorderInsets,
- kAppListDialogVerticalBorderInsets);
-
OnShowChildDialog();
- ShowAppInfoDialog(parent_window,
- dialog_bounds,
- profile,
- extension,
- base::Bind(&AppListControllerDelegate::OnCloseChildDialog,
- base::Unretained(this)));
+
+ // Since the AppListControllerDelegate is a leaky singleton, passing its
+ // raw pointer around is OK.
+ ShowAppInfoDialog(this, profile, extension);
}
void AppListControllerDelegate::UninstallApp(Profile* profile,
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_controller_delegate_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698