chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc - Issue 306023011: Add new DialogDelegate for dialogs in the App List

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Made AppInfoDialog a sub-view, and removed a lot of dependencies on close_callback and parent_windo… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc

index 56664b43a219c40582a71dc29ea8b2fd6e99b2b8..ba13597bb9ca671266966c2c686299c34e07e9e5 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc

@@ -4,13 +4,8 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.h"

-AppInfoTab::AppInfoTab(gfx::NativeWindow parent_window,

- Profile* profile,

- const extensions::Extension* app,

- const base::Closure& close_callback)

- : parent_window_(parent_window),

- profile_(profile),

- app_(app),

- close_callback_(close_callback) {}

+AppInfoTab::AppInfoTab(Profile* profile, const extensions::Extension* app)

+ : profile_(profile), app_(app) {

AppInfoTab::~AppInfoTab() {}