Add new DialogDelegate for dialogs in the App List

chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
index 3dded730feb65bf83bfdb660fe49a8f53eea4c92..1fcf40da0ede4beca503cf227440412f83884d02 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
@@ -33,7 +33,7 @@ using testing::Eq;
 
 class AppInfoPermissionsTabTest : public testing::Test {
  protected:
-  AppInfoPermissionsTabTest() : window_(NULL) {};
+  AppInfoPermissionsTabTest() {};

[tapted, 2014/06/16 06:11:56]

nit: there's a stray semicolon here

[sashab, 2014/06/16 07:01:20]

Done.

 
   scoped_ptr<base::DictionaryValue> ValidAppManifest() {
     return extensions::DictionaryBuilder()
@@ -49,7 +49,6 @@ class AppInfoPermissionsTabTest : public testing::Test {
         .Build();
   }
 
-  gfx::NativeWindow window_;
   TestingProfile profile_;
 
   // We need the UI thread in order to construct UI elements in the view.
@@ -63,7 +62,7 @@ TEST_F(AppInfoPermissionsTabTest, NoPermissionsObtainedCorrectly) {
           .SetManifest(ValidAppManifest())
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+  AppInfoPermissionsTab tab(&profile_, app);
 
   EXPECT_TRUE(tab.GetRequiredPermissions()->IsEmpty());
   EXPECT_TRUE(tab.GetRequiredPermissionMessages().empty());
@@ -93,7 +92,7 @@ TEST_F(AppInfoPermissionsTabTest, RequiredPermissionsObtainedCorrectly) {
                                              // a message
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+  AppInfoPermissionsTab tab(&profile_, app);
 
   const extensions::PermissionSet* required_permissions =
       tab.GetRequiredPermissions();
@@ -131,7 +130,7 @@ TEST_F(AppInfoPermissionsTabTest, OptionalPermissionsObtainedCorrectly) {
                                             // a message
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+  AppInfoPermissionsTab tab(&profile_, app);
 
   const extensions::PermissionSet* optional_permissions =
       tab.GetOptionalPermissions();
@@ -164,7 +163,7 @@ TEST_F(AppInfoPermissionsTabTest, RetainedFilePermissionsObtainedCorrectly) {
                       extensions::ListBuilder().Append("retainEntries")))))
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+  AppInfoPermissionsTab tab(&profile_, app);
 
   apps::SavedFilesService* files_service =
       apps::SavedFilesService::Get(&profile_);