Add new DialogDelegate for dialogs in the App List

chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_APP_INFO_TAB_H_
 #define CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_APP_INFO_TAB_H_
 
-#include "ui/gfx/native_widget_types.h"
 #include "ui/views/view.h"
 
-class AppInfoView;
 class Profile;
 
 namespace extensions {
 class Extension;
 }
 namespace views {
 class View;
 }
 
 // A tab in the App Info dialog that displays information for a particular
 // profile and app. Tabs in the App Info dialog extend this class.
 class AppInfoTab : public views::View {
  public:
-  AppInfoTab(gfx::NativeWindow parent_window,
-             Profile* profile,
-             const extensions::Extension* app,
-             const base::Closure& close_callback);
+  AppInfoTab(Profile* profile, const extensions::Extension* app);
 
   virtual ~AppInfoTab();
 
  protected:

[tapted, 2014/06/16 06:11:56]

protected data members are only allowed in test harnesses --
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Access_Control

But this is probably better to fix in a follow-up CL, since it's orthogonal.

[sashab, 2014/06/16 07:01:20]

I copied this 'pattern' from CreateApplicationShortcutView, which also uses
profile_ as a protected member. But yes, if it says so in the style guide, I'll
fix this in a follow-up CL.

-  gfx::NativeWindow parent_window_;
   Profile* profile_;
   const extensions::Extension* app_;
-  const base::Closure& close_callback_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AppInfoTab);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_APP_INFO_TAB_H_