Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 306023008: Use python fallback for unzipping in extracting build on mac if file is greater than 4GB (Closed)

Created:
6 years, 6 months ago by prasadv
Modified:
6 years, 6 months ago
Reviewers:
shatch, qyearsley, sh
CC:
chromium-reviews
Visibility:
Public.

Description

Use python fallback for unzipping in extracting build on mac if file is greater than 4GB BUG=379195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/bisect-perf-regression.py View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
prasadv
6 years, 6 months ago (2014-05-30 17:41:33 UTC) #1
qyearsley
LGTM I thought that this was already done before?
6 years, 6 months ago (2014-05-30 17:45:37 UTC) #2
shatch
On 2014/05/30 17:45:37, qyearsley wrote: > LGTM > > I thought that this was already ...
6 years, 6 months ago (2014-05-30 17:47:13 UTC) #3
prasadv
On 2014/05/30 17:47:13, shatch wrote: > On 2014/05/30 17:45:37, qyearsley wrote: > > LGTM > ...
6 years, 6 months ago (2014-05-30 18:07:05 UTC) #4
shatch
On 2014/05/30 18:07:05, prasadv wrote: > On 2014/05/30 17:47:13, shatch wrote: > > On 2014/05/30 ...
6 years, 6 months ago (2014-05-30 18:13:09 UTC) #5
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 6 months ago (2014-05-30 18:13:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/306023008/1
6 years, 6 months ago (2014-05-30 18:16:17 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 23:21:57 UTC) #8
Message was sent while issue was closed.
Change committed as 273929

Powered by Google App Engine
This is Rietveld 408576698