Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 306023004: Python prototype registration and session changes (Closed)

Created:
6 years, 6 months ago by Noam Samuel
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Python prototype registration and session changes 1. Fix registration in python prototype to work again 2. Fix sessions in python prototype to match current API on devsite 3. Fixed issue where "cyphertext" for sessions was going through double JSON serialization 4. Created empty session without encryption for testing purposes, this is different from the dummy session in that it is a complete passthrough BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273877

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -88 lines) Patch
M components/cloud_devices/tools/prototype/prototype.py View 1 2 13 chunks +118 lines, -88 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Noam Samuel
6 years, 6 months ago (2014-05-29 22:27:35 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm please also run pylint on this file https://codereview.chromium.org/306023004/diff/1/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/306023004/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode493 components/cloud_devices/tools/prototype/prototype.py:493: self.gcd.registrationTickets().patch(registrationTicketId=token, ...
6 years, 6 months ago (2014-05-29 22:59:47 UTC) #2
Noam Samuel
Plus fixed as many lint errors as I could. https://codereview.chromium.org/306023004/diff/1/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/306023004/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode493 components/cloud_devices/tools/prototype/prototype.py:493: ...
6 years, 6 months ago (2014-05-30 17:50:34 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-30 17:54:32 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-05-30 17:54:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/306023004/40001
6 years, 6 months ago (2014-05-30 17:57:26 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 18:04:45 UTC) #7
Message was sent while issue was closed.
Change committed as 273877

Powered by Google App Engine
This is Rietveld 408576698