tools/valgrind/vbug210481.patch - Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/valgrind/vbug210481.patch

Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running... Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # See https://bugs.kde.org/show_bug.cgi?id=210481

	2 Index: guest_amd64_toIR.c

	3 ===================================================================

	4 --- VEX/priv/guest_amd64_toIR.c (Revision 1924)
	Timur Iskhodzhanov 2009/10/21 09:33:28 why not 1913? why not 1913?
	5 +++ VEX/priv/guest_amd64_toIR.c (Arbeitskopie)

	6 @@ -14597,7 +14597,7 @@

	7 /* There is no encoding for 32-bit pop in 64-bit mode.

	8 So sz==4 actually means sz==8. */

	9 if (haveF2orF3(pfx)) goto decode_failure;

	10 - vassert(sz == 2 \|\| sz == 4);

	11 + vassert(sz == 2 \|\| sz == 4 \|\| sz == 8);

	12 if (sz == 4) sz = 8;

	13 if (sz != 8) goto decode_failure; // until we know a sz==2 test case exis ts

	14

OLD	NEW