tools/valgrind/vbug205541.patch - Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/valgrind/vbug205541.patch

Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running... Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # See https://bugs.kde.org/show_bug.cgi?id=205541#c1

	2 Index: memcheck/mc_main.c

	3 ===================================================================

	4 --- memcheck/mc_main.c (revision 10877)
	Timur Iskhodzhanov 2009/10/21 09:33:28 why not 10880? why not 10880?
	5 +++ memcheck/mc_main.c (working copy)

	6 @@ -3708,7 +3708,14 @@

	7 if (rr \|\| ww \|\| xx)

	8 MC_(make_mem_defined)(a, len);

	9 else

	10 - MC_(make_mem_noaccess)(a, len);

	11 + MC_(make_mem_defined)(a, len);
	Timur Iskhodzhanov 2009/10/21 09:33:28 In this case the condition above doesn't make sens In this case the condition above doesn't make sense. However, I accept this as a workaround
	12 + /* State after mmap(,,PROT_NONE,,,) should match

	13 + * state after mprotect(,,PROT_NONE): the operating system

	14 + * will trap any access, but any subsequent mprotect(,,PROT_R\|W\|X)

	15 + * will re-instate the previous V bits [in this case, all valid].

	16 + * See comment in mc_pre_clo_init() re:

	17 + * VG_(track_change_mem_mprotect) ( NULL );

	18 + */

	19 }

	20

	21 static

OLD	NEW