Added a D-Bus filter to find out when flimflamd dies, so that we can clean up and exit.

Added a D-Bus filter to find out when flimflamd dies, so that we can clean up and exit.

BUG=chromium-os:5035
TEST=Start flimflamd. Observe that it starts dhcpcd to configure eth0.
Kill flimflamd with a signal that it doesn't catch (SIGQUIT or SIGSEGV
will do). Observe that dhcpcd exits. Also tested the "normal" case
in which flimflamd is terminated with a SIGTERM, and observed that
it behaves as it did before, i.e., it does an orderly shutdown and
sends a release request to dhcpcd.

[Sam Leffler, 2010-07-26 21:04:30]

LGTM

[kobi, 2010-07-27 18:07:02]

http://codereview.chromium.org/3060016/diff/1/2
File dhcpcd-dbus.c (right):

http://codereview.chromium.org/3060016/diff/1/2#newcode577
dhcpcd-dbus.c:577: strlen(new_owner) == 0) {
I think it is better to check new_owner against null || '\0'

[Sam Leffler, 2010-07-27 18:11:48]

Why?  Is there a reference for this stuff?

-Sam

On Tue, Jul 27, 2010 at 11:07 AM, <kobic@codeaurora.org> wrote:

>
> http://codereview.chromium.org/3060016/diff/1/2
> File dhcpcd-dbus.c (right):
>
> http://codereview.chromium.org/3060016/diff/1/2#newcode577
> dhcpcd-dbus.c:577: strlen(new_owner) == 0) {
> I think it is better to check new_owner against null || '\0'
>
>
> http://codereview.chromium.org/3060016/show
>

[Eric Shienbrood, 2010-07-27 18:18:31]

On 2010/07/27 18:11:48, Sam Leffler wrote:
> Why?  Is there a reference for this stuff?
> 
> -Sam
> 
> On Tue, Jul 27, 2010 at 11:07 AM, <mailto:kobic@codeaurora.org> wrote:
> 
> >
> > http://codereview.chromium.org/3060016/diff/1/2
> > File dhcpcd-dbus.c (right):
> >
> > http://codereview.chromium.org/3060016/diff/1/2#newcode577
> > dhcpcd-dbus.c:577: strlen(new_owner) == 0) {
> > I think it is better to check new_owner against null || '\0'
> >
> >
> > http://codereview.chromium.org/3060016/show
> >
> 

There is no reference as far as I can discover. Running dbus-monitor, I observed
that the signal arg that specifies the old (or new) owner is an empty string
when the owner disappears (or appears).