Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 306001: Heap profiler: skip byte arrays that represent free list blocks when counting allocated objects. (Closed)

Created:
11 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Heap profiler: skip byte arrays that represent free list blocks when counting allocated objects. This is the one cause of the problem reported in http://crbug/23623. Also it will be needed to change the way the total heap size is reported by using Heap::CommittedMemory introduced in http://codereview.chromium.org/261037. BUG=http://crbug/23623 Committed: http://code.google.com/p/v8/source/detail?r=3098

Patch Set 1 #

Total comments: 2

Patch Set 2 : added the third type to check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/heap-profiler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/spaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/spaces.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/spaces-inl.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
11 years, 2 months ago (2009-10-20 06:14:03 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/306001/diff/1/3 File src/spaces-inl.h (right): http://codereview.chromium.org/306001/diff/1/3#newcode366 Line 366: object->map() == Heap::raw_unchecked_two_pointer_filler_map(); How about the one_pointer_filler_map?
11 years, 2 months ago (2009-10-20 06:32:36 UTC) #2
mnaganov (inactive)
11 years, 2 months ago (2009-10-20 06:41:24 UTC) #3
http://codereview.chromium.org/306001/diff/1/3
File src/spaces-inl.h (right):

http://codereview.chromium.org/306001/diff/1/3#newcode366
Line 366: object->map() == Heap::raw_unchecked_two_pointer_filler_map();
On 2009/10/20 06:32:36, Søren Gjesse wrote:
> How about the one_pointer_filler_map?

Yes, that's my poor attention. Thanks!

Powered by Google App Engine
This is Rietveld 408576698