tools/gn/secondary/third_party/icu/BUILD.gn - Issue 305993002: Update skia and ui GN builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/secondary/third_party/icu/BUILD.gn

Issue 305993002: Update skia and ui GN builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: gesture detection updates Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/secondary/third_party/icu/BUILD.gn

diff --git a/tools/gn/secondary/third_party/icu/BUILD.gn b/tools/gn/secondary/third_party/icu/BUILD.gn

index 21c4efa714b6b854bef44fbdd160b017865d1729..e4d030a8d3781acbfb74037b616fc6f6bc6576ff 100644

--- a/tools/gn/secondary/third_party/icu/BUILD.gn

+++ b/tools/gn/secondary/third_party/icu/BUILD.gn

@@ -24,7 +24,7 @@ config("icu_config") {

# Config used only by ICU code.

config("icu_code") {

- if (component_mode == "static_library") {

+ if (component_mode != "shared_library") {

defines = [ "U_STATIC_IMPLEMENTATION" ]

}

@@ -426,7 +426,7 @@ if (is_win) {

outputs = [ "$root_out_dir/icudt.dll" ]

}

} else {

- static_library("icudata") {

+ source_set("icudata") {

sources = [

# These are hand-generated, but will do for now. The linux version is an

# identical copy of the (mac) icudt46l_dat.S file, modulo removal of the

« no previous file with comments | « skia/skia_gn_files.gypi ('k') | ui/base/BUILD.gn » ('j') | no next file with comments »