components/bookmarks/test/test_bookmark_client.cc - Issue 305973004: BookmarkClient can add extra nodes to BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/test/test_bookmark_client.cc

Issue 305973004: BookmarkClient can add extra nodes to BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/test/test_bookmark_client.cc

diff --git a/components/bookmarks/test/test_bookmark_client.cc b/components/bookmarks/test/test_bookmark_client.cc

index 6151032d9661bc01101eddbb60cf7a5d40791f24..4568f9f30f665a75037d14d2d9f271ed668a2a16 100644

--- a/components/bookmarks/test/test_bookmark_client.cc

+++ b/components/bookmarks/test/test_bookmark_client.cc

@@ -20,8 +20,10 @@ scoped_ptr<BookmarkModel> TestBookmarkClient::CreateModel(bool index_urls) {

bool TestBookmarkClient::IsPermanentNodeVisible(int node_type) {

DCHECK(node_type == BookmarkNode::BOOKMARK_BAR ||

node_type == BookmarkNode::OTHER_NODE ||

- node_type == BookmarkNode::MOBILE);

- return node_type != BookmarkNode::MOBILE;

+ node_type == BookmarkNode::MOBILE ||

+ node_type == BookmarkNode::MANAGED);

+ return node_type != BookmarkNode::MOBILE &&

+ node_type != BookmarkNode::MANAGED;

}

void TestBookmarkClient::RecordAction(const base::UserMetricsAction& action) {