chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc - Issue 305973004: BookmarkClient can add extra nodes to BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 305973004: BookmarkClient can add extra nodes to BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

index 4d4f36373a164403d6e391ee319c5e0b23cb8b80..4d275417df220131a53f6f7c82a97dfb61f23f06 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

@@ -498,7 +498,7 @@ BookmarkEditorView::EditorNode* BookmarkEditorView::CreateRootNode() {

DCHECK(root_node->child_count() >= 2 && root_node->child_count() <= 3);

sky 2014/05/30 22:31:37 Don't you need to adjust this?

Joao da Silva 2014/06/01 13:32:07 Yes, done.

DCHECK_EQ(BookmarkNode::BOOKMARK_BAR, bb_root_node->GetChild(0)->type());

DCHECK_EQ(BookmarkNode::OTHER_NODE, bb_root_node->GetChild(1)->type());

- if (root_node->child_count() == 3)

+ if (root_node->child_count() >= 3)

DCHECK_EQ(BookmarkNode::MOBILE, bb_root_node->GetChild(2)->type());

return root_node;

}