Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.cc

Issue 305973004: BookmarkClient can add extra nodes to BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanups Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/chrome_bookmark_client.cc
diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.cc b/chrome/browser/bookmarks/chrome_bookmark_client.cc
index b57fb06f3c37ae0563662a19d708b6557b4a880a..45047822ee3bfa7153fc7d220b027e95374f235a 100644
--- a/chrome/browser/bookmarks/chrome_bookmark_client.cc
+++ b/chrome/browser/bookmarks/chrome_bookmark_client.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
+#include "base/bind.h"
#include "base/logging.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/favicon/favicon_changed_details.h"
@@ -99,19 +100,40 @@ void ChromeBookmarkClient::GetTypedCountForNodes(
}
}
+bool ChromeBookmarkClient::IsPermanentNodeVisible(
+ const BookmarkPermanentNode* node) {
+ DCHECK(node->type() == BookmarkNode::BOOKMARK_BAR ||
+ node->type() == BookmarkNode::OTHER_NODE ||
+ node->type() == BookmarkNode::MOBILE);
+#if !defined(OS_IOS)
+ return node->type() != BookmarkNode::MOBILE;
+#else
+ return node->type() == BookmarkNode::MOBILE;
+#endif
+}
+
void ChromeBookmarkClient::RecordAction(const base::UserMetricsAction& action) {
content::RecordAction(action);
}
-bool ChromeBookmarkClient::IsPermanentNodeVisible(int node_type) {
- DCHECK(node_type == BookmarkNode::BOOKMARK_BAR ||
- node_type == BookmarkNode::OTHER_NODE ||
- node_type == BookmarkNode::MOBILE);
-#if !defined(OS_IOS)
- return node_type != BookmarkNode::MOBILE;
-#else
- return node_type == BookmarkNode::MOBILE;
-#endif
+bookmarks::LoadExtraCallback ChromeBookmarkClient::GetLoadExtraNodesCallback() {
+ return base::Bind(&ChromeBookmarkClient::LoadExtraNodes);
+}
+
+bool ChromeBookmarkClient::CanRemoveNode(const BookmarkNode* node) {
+ return true;
+}
+
+bool ChromeBookmarkClient::CanSetTitle(const BookmarkNode* permanent_node) {
+ return false;
+}
+
+bool ChromeBookmarkClient::CanSyncNode(const BookmarkNode* node) {
+ return true;
+}
+
+bool ChromeBookmarkClient::CanReorderChildren(const BookmarkNode* parent) {
+ return true;
}
void ChromeBookmarkClient::Observe(
@@ -152,3 +174,10 @@ void ChromeBookmarkClient::BookmarkAllNodesRemoved(
const std::set<GURL>& removed_urls) {
NotifyHistoryOfRemovedURLs(profile_, removed_urls);
}
+
+// static
+bookmarks::BookmarkPermanentNodeList ChromeBookmarkClient::LoadExtraNodes(
+ int64* next_id) {
+ // TODO(joaodasilva): load the managed node. http://crbug.com/49598
+ return bookmarks::BookmarkPermanentNodeList();
+}

Powered by Google App Engine
This is Rietveld 408576698