Issue 305963014: Introduce and use type casting functions for several HTMLCollection types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305963014: Introduce and use type casting functions for several HTMLCollection types (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
haraken, esprehn, adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce and use type casting functions for several HTMLCollection types Introduce and use type casting functions for several HTMLCollection types: - ClassCollection - TagCollection - HTMLAllCollection - HTMLFormControlsCollection - HTMLOptionsCollection - HTMLTagCollection R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175333

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -16 lines)			Patch
M	Source/bindings/v8/custom/V8HTMLCollectionCustom.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/ClassCollection.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/TagCollection.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLAllCollection.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLAllCollection.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLFormControlsCollection.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLOptionsCollection.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/305963014/1

6 years, 6 months ago (2014-06-03 02:15:39 UTC) #4

Message was sent while issue was closed.

Change committed as 175333

Expand Messages | Collapse Messages