Add GetStoreSize() to ImageStore to know the actual db size.

Add GetStoreSizeInBytes() to ImageStore to know the actual db size.

We will limit the enhanced bookmark image store database size
to ensure that the db file size is reasonable. So add a function
to query the actual file size.

BUG=378853
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274297

[sky, 2014-05-29 21:51:04]

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/image_store.h (right):

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/image_store.h:55: virtual int64 GetStoreSize() =
0;
Add description, and it isn't clear what the returned value is in. Maybe
GetStoreSizeInBytes. Also document what -1 means.

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/persistent_image_store.cc (right):

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/persistent_image_store.cc:203: if (OpenDatabase()
!= sql::INIT_OK)
Do you really need to open the db here?

[Kibeom Kim (inactive), 2014-05-29 23:07:14]

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/image_store.h (right):

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/image_store.h:55: virtual int64 GetStoreSize() =
0;
On 2014/05/29 21:51:05, sky wrote:
> Add description, and it isn't clear what the returned value is in. Maybe
> GetStoreSizeInBytes. Also document what -1 means.

Done.

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/persistent_image_store.cc (right):

https://codereview.chromium.org/305963004/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/persistent_image_store.cc:203: if (OpenDatabase()
!= sql::INIT_OK)
On 2014/05/29 21:51:05, sky wrote:
> Do you really need to open the db here?

Done.

[sky, 2014-05-30 02:27:49]

LGTM

[Kibeom Kim (inactive), 2014-05-30 02:36:43]

The CQ bit was checked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2014-05-30 02:36:51]

The CQ bit was unchecked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2014-05-30 02:38:11]

+OWNER reed for "+third_party/skia" in DEPS

[reed1, 2014-05-30 12:17:40]

lgtm

[Kibeom Kim (inactive), 2014-05-30 14:30:54]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-30 14:32:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/305963004/20001

[commit-bot: I haz the power, 2014-05-30 18:23:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-31 02:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 02:08:27]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[Kibeom Kim (inactive), 2014-05-31 02:38:47]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-31 02:41:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/305963004/20001

[commit-bot: I haz the power, 2014-05-31 04:36:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-31 06:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 06:31:01]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[Kibeom Kim (inactive), 2014-06-02 08:10:04]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-06-02 08:10:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/305963004/40001

[commit-bot: I haz the power, 2014-06-02 17:27:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-02 19:16:41]

Change committed as 274297