Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 30593005: IPC pickling optimizations for geometry types. (Closed)

Created:
7 years, 2 months ago by danakj
Modified:
7 years, 2 months ago
Reviewers:
kenrb, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Visibility:
Public.

Description

IPC pickling optimizations for geometry types. Pass gfx::Transform, gfx::Size(F), gfx::Rect(F) and gfx::Vector2d(F) with a single Write call to the pickler. content_perftests results on a release official build: BEFORE *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_1_4000= 47 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_1_100000= 1808 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_4000_4000= 1896 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_100000_100000= 59606 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyRenderPasses_10000_100= 60336 us AFTER *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_1_4000= 50 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_1_100000= 1888 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_4000_4000= 728 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyQuads_100000_100000= 23771 us *RESULT mean_frame_serialization_time: DelegatedFrame_ManyRenderPasses_10000_100= 24118 us This gives about a 2-3x improvement in time to serialize shared quad states and render passes. R=piman BUG=307480 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230823

Patch Set 1 #

Patch Set 2 : ccmessagesperf-geom: #

Total comments: 2

Patch Set 3 : ccmessagesperf-geom: fixtypos #

Total comments: 1

Patch Set 4 : ccmessagesperf-geom: allownegativevectorsstill #

Patch Set 5 : ccmessagesperf-geom: maintain check on Rect size from before #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -143 lines) Patch
M content/common/cc_messages.cc View 1 chunk +26 lines, -91 lines 0 comments Download
M content/public/common/common_param_traits.cc View 1 2 3 4 6 chunks +47 lines, -52 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
7 years, 2 months ago (2013-10-22 19:27:10 UTC) #1
piman
LGTM, but you have some typos https://codereview.chromium.org/30593005/diff/30001/content/public/common/common_param_traits.cc File content/public/common/common_param_traits.cc (right): https://codereview.chromium.org/30593005/diff/30001/content/public/common/common_param_traits.cc#newcode209 content/public/common/common_param_traits.cc:209: r->set_width(values[1]); set_height https://codereview.chromium.org/30593005/diff/30001/content/public/common/common_param_traits.cc#newcode230 ...
7 years, 2 months ago (2013-10-22 20:14:37 UTC) #2
danakj
On 2013/10/22 20:14:37, piman wrote: > LGTM, but you have some typos /o\ I should ...
7 years, 2 months ago (2013-10-22 20:15:10 UTC) #3
danakj
+kenrb for IPC security review. We'll be reading/writing an array of int/floats instead of reading/writing ...
7 years, 2 months ago (2013-10-22 20:18:34 UTC) #4
danakj
https://codereview.chromium.org/30593005/diff/190001/content/public/common/common_param_traits.cc File content/public/common/common_param_traits.cc (right): https://codereview.chromium.org/30593005/diff/190001/content/public/common/common_param_traits.cc#newcode250 content/public/common/common_param_traits.cc:250: if (values[0] < 0 || values[1] < 0) Oh ...
7 years, 2 months ago (2013-10-22 20:28:19 UTC) #5
danakj
kenrb: ping, or let me know if I should get someone else please
7 years, 2 months ago (2013-10-24 14:53:34 UTC) #6
kenrb
lgtm
7 years, 2 months ago (2013-10-24 17:40:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/30593005/480001
7 years, 2 months ago (2013-10-24 18:02:49 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 21:46:44 UTC) #9
Message was sent while issue was closed.
Change committed as 230823

Powered by Google App Engine
This is Rietveld 408576698