Apply matrix early in draw bitmap

Apply matrix early in draw bitmap

Committed: http://code.google.com/p/skia/source/detail?r=11930

Reverted: https://code.google.com/p/skia/source/detail?r=11932

Committed: http://code.google.com/p/skia/source/detail?r=11933

[bsalomon, 2013-10-20 14:14:17]

This will make it easier to consider the clip in the decision to tile.

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1384: needsTextureDomain = may_color_bleed(srcRect,
transformedRect, matrix);
I think this was supposed take the full matrix and not just m in the old code
(as it now does).

[robertphillips, 2013-10-20 21:21:39]

lgtm + 1 question

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1170: 
How does this get undone?

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1384: needsTextureDomain = may_color_bleed(srcRect,
transformedRect, matrix);
I agree

[bsalomon, 2013-10-21 13:19:10]

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/30593003/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1170: 
On 2013/10/20 21:21:39, robertphillips wrote:
> How does this get undone?

It doesn't :) But SkGpuDevice sets the canvas matrix on GrContext on every draw.

[commit-bot: I haz the power, 2013-10-21 13:26:26]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/30593003/1

[commit-bot: I haz the power, 2013-10-21 14:48:19]

Change committed as 11880

[Stephen White, 2013-10-21 18:00:07]

On 2013/10/21 14:48:19, I haz the power (commit-bot) wrote:
> Change committed as 11880

Just FYI, this change seems to have broken layout test
css3/filters/effect-reference-composite-hw.html.  Looks like it's using a
stale/old texture (sorry, don't the image diffs handy).

[robertphillips, 2013-10-21 21:31:13]

Reverted in r11899 due to layout test failure

[bsalomon, 2013-10-23 19:40:56]

Reopened and new patchsets uploaded. Adding Stephen for SkImageFilterUtils and
imagefiltersgraph changes.

[Stephen White, 2013-10-23 19:48:51]

LGTM

[commit-bot: I haz the power, 2013-10-23 19:58:35]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/30593003/150001

[commit-bot: I haz the power, 2013-10-23 20:27:51]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/30593003/320001

[commit-bot: I haz the power, 2013-10-23 21:06:57]

Change committed as 11930

[commit-bot: I haz the power, 2013-10-24 01:35:32]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/30593003/400001

[commit-bot: I haz the power, 2013-10-24 01:46:18]

Change committed as 11933