Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 305923002: test_runner: Migrate MockWebRTCDataChannelHandler to Chromium C++ style. (Closed)

Created:
6 years, 6 months ago by Nikhil
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

test_runner: Migrate MockWebRTCDataChannelHandler to Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Fix member variables names. 3) Rename file name to mock_webrtc_data_channel_handler. BUG=360000 TEST=None. No functional changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -176 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebRTCDataChannelHandler.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebRTCDataChannelHandler.cpp View 1 chunk +0 lines, -118 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
A content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +57 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc View 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikhil
PTAL. Thanks! If you have any review comments, then please let me know. I'll rework ...
6 years, 6 months ago (2014-05-29 13:55:11 UTC) #1
Nikhil
Adding Dirk and Abarth for review. PTAL. Thanks! If you've review comments then please let ...
6 years, 6 months ago (2014-05-30 07:36:24 UTC) #2
Dirk Pranke
it doesn't look like you actually changed any of the naming styles in the file; ...
6 years, 6 months ago (2014-05-30 18:25:13 UTC) #3
Dirk Pranke
On 2014/05/30 18:25:13, Dirk Pranke wrote: > it doesn't look like you actually changed any ...
6 years, 6 months ago (2014-05-30 20:32:45 UTC) #4
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 6 months ago (2014-05-30 21:45:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/305923002/1
6 years, 6 months ago (2014-05-30 21:49:53 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:27:15 UTC) #7
Message was sent while issue was closed.
Change committed as 274014

Powered by Google App Engine
This is Rietveld 408576698