Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 305913002: drive: Replace GetResourceListCallback in DriveServiceInterface with FileListCallback (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Replace GetResourceListCallback in DriveServiceInterface with FileListCallback Replace GetResourceListCallback with FileListCallback. Rename GetAllResourceList and GetResourceListInDirectory to GetAllFileList and GetFileListInDirectory. Rename FakeDriveService counter variables. Remove GetOldestCreatedFolderResource in drive_backend_util.cc and merged the code to folder_creator.cc BUG=231125 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274175

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -546 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 5 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 12 chunks +15 lines, -64 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 7 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 11 chunks +70 lines, -67 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 10 chunks +115 lines, -129 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 7 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 1 chunk +21 lines, -22 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 13 chunks +28 lines, -53 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 4 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
Sorry for sending a big change. kinaba@: Please review chrome/browser/chromeos/drive and chrome/browser/drive tzik@: Please review ...
6 years, 6 months ago (2014-05-30 08:32:06 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-05-30 09:08:32 UTC) #2
kinaba
lgtm
6 years, 6 months ago (2014-05-30 09:41:09 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-02 04:28:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/305913002/100001
6 years, 6 months ago (2014-06-02 04:29:12 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 05:51:57 UTC) #6
Message was sent while issue was closed. 
Change committed as 274175

Powered by Google App Engine
This is Rietveld 408576698