Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 305903002: Revert of Bring Syzygy binaries in using a script rather than as a dependency. (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Bring Syzygy binaries in using a script rather than as a dependency. (https://codereview.chromium.org/306543006/) Reason for revert: This CL broke check_licenses on Android Builder: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/58461 Original issue's description: > Bring Syzygy binaries in using a script rather than as a dependency. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273353 TBR=siggi@chromium.org,chrisha@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -36 lines) Patch
M DEPS View 2 chunks +5 lines, -11 lines 0 comments Download
M build/get_syzygy_binaries.py View 4 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
Created Revert of Bring Syzygy binaries in using a script rather than as a dependency.
6 years, 6 months ago (2014-05-29 09:16:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/305903002/1
6 years, 6 months ago (2014-05-29 09:17:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 09:19:28 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-05-29 09:19:29 UTC) #4
chrisha
6 years, 6 months ago (2014-05-29 13:11:51 UTC) #5
Message was sent while issue was closed.
This was already reverted here:

https://codereview.chromium.org/300223013/

Powered by Google App Engine
This is Rietveld 408576698