Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 305883002: Switch arguments to const Length references for performance (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBoxModelObject.h ('k') | Source/core/rendering/style/BasicShapes.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 int RenderBoxModelObject::pixelSnappedOffsetWidth() const 415 int RenderBoxModelObject::pixelSnappedOffsetWidth() const
416 { 416 {
417 return snapSizeToPixel(offsetWidth(), offsetLeft()); 417 return snapSizeToPixel(offsetWidth(), offsetLeft());
418 } 418 }
419 419
420 int RenderBoxModelObject::pixelSnappedOffsetHeight() const 420 int RenderBoxModelObject::pixelSnappedOffsetHeight() const
421 { 421 {
422 return snapSizeToPixel(offsetHeight(), offsetTop()); 422 return snapSizeToPixel(offsetHeight(), offsetTop());
423 } 423 }
424 424
425 LayoutUnit RenderBoxModelObject::computedCSSPadding(Length padding) const 425 LayoutUnit RenderBoxModelObject::computedCSSPadding(const Length& padding) const
426 { 426 {
427 LayoutUnit w = 0; 427 LayoutUnit w = 0;
428 if (padding.isPercent()) 428 if (padding.isPercent())
429 w = containingBlockLogicalWidthForContent(); 429 w = containingBlockLogicalWidthForContent();
430 return minimumValueForLength(padding, w); 430 return minimumValueForLength(padding, w);
431 } 431 }
432 432
433 RoundedRect RenderBoxModelObject::getBackgroundRoundedRect(const LayoutRect& bor derRect, InlineFlowBox* box, LayoutUnit inlineBoxWidth, LayoutUnit inlineBoxHeig ht, 433 RoundedRect RenderBoxModelObject::getBackgroundRoundedRect(const LayoutRect& bor derRect, InlineFlowBox* box, LayoutUnit inlineBoxWidth, LayoutUnit inlineBoxHeig ht,
434 bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const 434 bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const
435 { 435 {
(...skipping 2400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2836 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent()); 2836 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent());
2837 for (RenderObject* child = startChild; child && child != endChild; ) { 2837 for (RenderObject* child = startChild; child && child != endChild; ) {
2838 // Save our next sibling as moveChildTo will clear it. 2838 // Save our next sibling as moveChildTo will clear it.
2839 RenderObject* nextSibling = child->nextSibling(); 2839 RenderObject* nextSibling = child->nextSibling();
2840 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert); 2840 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert);
2841 child = nextSibling; 2841 child = nextSibling;
2842 } 2842 }
2843 } 2843 }
2844 2844
2845 } // namespace WebCore 2845 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBoxModelObject.h ('k') | Source/core/rendering/style/BasicShapes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698