Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 305843003: Update chrome.identity API documentation to mention best practices. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
Michael Courage
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Update chrome.identity API documentation to mention best practices. This adds a tip on best practices to the documentation for getAuthToken, and also updates the tip on launchWebAuthFlow to correct an inaccuracy. BUG=372279 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274184

Patch Set 1 #

Patch Set 2 : Line limit #

Patch Set 3 : too much coffee obviously #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/common/extensions/api/identity.idl View 1 2 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
benwells
6 years, 6 months ago (2014-05-29 02:49:32 UTC) #1
Michael Courage
ltm
6 years, 6 months ago (2014-05-29 17:16:51 UTC) #2
benwells
On 2014/05/29 17:16:51, Michael Courage wrote: > ltm Did you miss a g?
6 years, 6 months ago (2014-05-29 20:44:04 UTC) #3
Michael Courage
lgtm i did
6 years, 6 months ago (2014-05-29 20:46:14 UTC) #4
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-05-29 21:27:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/305843003/40001
6 years, 6 months ago (2014-05-29 21:29:12 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 00:58:00 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 01:21:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/189908)
6 years, 6 months ago (2014-05-30 01:21:48 UTC) #9
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-02 06:27:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/305843003/40001
6 years, 6 months ago (2014-06-02 06:27:59 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:02:23 UTC) #12
Message was sent while issue was closed.
Change committed as 274184

Powered by Google App Engine
This is Rietveld 408576698