Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 305833002: Main frame should remain scrollable if the fullscreen element is the document (Closed)

Created:
6 years, 6 months ago by trchen
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen
Visibility:
Public.

Description

Main frame should remain scrollable if the fullscreen element is the document In a previous CL we disabled main frame impl-side scrolling if there is a fullscreen element because the fullscreen element can balloon up scroll events to the (invisible) main frame layer and cause weird artifacts. However if the element that enter fullscreen is the main frame document itself, we should allow it remain scrollable. BUG=376699 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175089

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
trchen
Context: https://codereview.chromium.org/200943002/ Test coming soon.
6 years, 6 months ago (2014-05-29 00:15:18 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 6 months ago (2014-05-29 00:18:41 UTC) #2
trchen
Test added. PTAL, thanks!
6 years, 6 months ago (2014-05-29 00:42:14 UTC) #3
aelias_OOO_until_Jul13
lgtm, still needs OWNERS approval for Source/core
6 years, 6 months ago (2014-05-29 02:58:34 UTC) #4
Hajime Morrita
lgtm. Just for curious, what about other browsers? IIRC the fullscreen API is supported by ...
6 years, 6 months ago (2014-05-29 20:00:23 UTC) #5
trchen
On 2014/05/29 20:00:23, morrita wrote: > lgtm. > > Just for curious, what about other ...
6 years, 6 months ago (2014-05-29 21:01:39 UTC) #6
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 6 months ago (2014-05-29 21:01:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/305833002/20001
6 years, 6 months ago (2014-05-29 21:02:49 UTC) #8
trchen
On 2014/05/29 21:01:39, trchen wrote: > On 2014/05/29 20:00:23, morrita wrote: > > lgtm. > ...
6 years, 6 months ago (2014-05-29 21:03:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-29 22:39:59 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 00:58:43 UTC) #11
Message was sent while issue was closed.
Change committed as 175089

Powered by Google App Engine
This is Rietveld 408576698