Issue 305823005: [Android WebView] Fix hang in popup window flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305823005: [Android WebView] Fix hang in popup window flow. (Closed)

Created:
6 years, 6 months ago by benm (inactive)

Modified:
6 years, 6 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android WebView] Fix hang in popup window flow. It's possible that we end up hanging the browser process waiting for the response to a popup window due to a bug in the AwContents hand-over when swapping out the popup content into the user-supplied WebView. This patch ensures that we don't end up with two AwContents instances pointing to the same java AwContentsClientBridge java object during deletion. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277816

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	android_webview/native/aw_contents.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/305823005/1

6 years, 6 months ago (2014-06-17 14:44:03 UTC) #4

Message was sent while issue was closed.

Change committed as 277816

Expand Messages | Collapse Messages