Issue 305813005: DevTools: Fix regression that slows down "Goto Source" dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305813005: DevTools: Fix regression that slows down "Goto Source" dialog (Closed)

Created:
6 years, 6 months ago by lushnikov

Modified:
6 years, 6 months ago

Reviewers:
apavlov, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Fix regression that slows down "Goto Source" dialog The regression was caused by r174810. The root cause is the implementation of WebInspector.StaticViewportElement which doesn't support lazy DOM element creation. So every time the viewport processed cumulative heights of inner elements, it actually forced all DOM elements for viewport to be created. To keep things simple, the patch moves fastHeight calls out of ViewportElement interface into ViewportProvider. BUG=377749 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175059

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -22 lines)			Patch
M	Source/devtools/front_end/console/ConsoleView.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sources/FilteredItemSelectionDialog.js	View	1 chunk	+15 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/ui/ViewportControl.js	View	6 chunks	+10 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/305813005/1

6 years, 6 months ago (2014-05-29 09:44:31 UTC) #4

lushnikov

6 years, 6 months ago (2014-05-29 15:34:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r175059 (presubmit successful).

Expand Messages | Collapse Messages