Add images used by webkit for the speech input button.

Add images used by webkit for the speech input button.

The try servers seem to not support testing these types of resource/image additions, hence all builds fail in try. However I have verified that this builds fine on my windows,mac and linux machines.

Please advise if any of the changes in the GRD or webkitclient_impl.cc
need to be inside #if ENABLE_INPUT_SPEECH. I did not add the ifdef since
I didn't see any for other such features in both these files.

BUG=none
TEST=none yet as the feature is still being implemented and not enabled

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53991

[jorlow, 2010-07-28 15:59:48]

Marcus knows more about this stuff.

[bulach, 2010-07-28 16:12:55]

the contents itself LGTM, one comment below about sorting.

I can't answer the question about the ifdef flag though. jeremy?

http://codereview.chromium.org/3058019/diff/1/5
File webkit/glue/webkit_resources.grd (right):

http://codereview.chromium.org/3058019/diff/1/5#newcode47
webkit/glue/webkit_resources.grd:47: <include name="IDR_INPUT_SPEECH_WAITING"
file="resources\input_speech_waiting.png" type="BINDATA" />
I think pkasting sorted by "name" attribute, so these should be a bit higher up

[jorlow, 2010-07-28 16:22:32]

Donno...guess we need to ask him.

On Wed, Jul 28, 2010 at 5:12 PM, <bulach@chromium.org> wrote:

> the contents itself LGTM, one comment below about sorting.
>
> I can't answer the question about the ifdef flag though. jeremy?
>
>
> http://codereview.chromium.org/3058019/diff/1/5
> File webkit/glue/webkit_resources.grd (right):
>
> http://codereview.chromium.org/3058019/diff/1/5#newcode47
> webkit/glue/webkit_resources.grd:47: <include
>
> name="IDR_INPUT_SPEECH_WAITING"
> file="resources\input_speech_waiting.png" type="BINDATA" />
> I think pkasting sorted by "name" attribute, so these should be a bit
> higher up
>
>
> http://codereview.chromium.org/3058019/show
>

[Peter Kasting, 2010-07-28 18:13:53]

http://codereview.chromium.org/3058019/diff/1/5
File webkit/glue/webkit_resources.grd (right):

http://codereview.chromium.org/3058019/diff/1/5#newcode47
webkit/glue/webkit_resources.grd:47: <include name="IDR_INPUT_SPEECH_WAITING"
file="resources\input_speech_waiting.png" type="BINDATA" />
On 2010/07/28 16:12:55, bulach wrote:
> I think pkasting sorted by "name" attribute, so these should be a bit higher
up

Yes, please maintain the order, don't just add to the end of the list.

[Satish, 2010-07-28 19:11:16]

Updated the order now. Please take another look.

[bulach, 2010-07-28 19:15:13]

LGTM


On 2010/07/28 19:11:16, Satish wrote:
> Updated the order now. Please take another look.