Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 305753002: Spin off just SkLazyFnPtr from 305513002. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Spin off just SkLazyFnPtr from 305513002. The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in SkUtils on ARM. We can do a lot better for function pointers. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14929 Committed: http://code.google.com/p/skia/source/detail?r=14938

Patch Set 1 #

Patch Set 2 : Fn -> F #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : rebase #

Patch Set 6 : SkThreadPriv again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -34 lines) Patch
A src/core/SkLazyFnPtr.h View 1 4 5 1 chunk +58 lines, -0 lines 0 comments Download
A src/core/SkThreadPriv.h View 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
M src/core/SkUtils.cpp View 2 chunks +16 lines, -34 lines 0 comments Download
M src/ports/SkAtomics_sync.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ports/SkAtomics_win.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 6 months ago (2014-05-28 18:34:30 UTC) #1
bungeman-skia
lgtm, so long as SkThread.h and SkThreadPriv.h all get back together soon.
6 years, 6 months ago (2014-05-28 19:04:27 UTC) #2
mtklein
On 2014/05/28 19:04:27, bungeman1 wrote: > lgtm, so long as SkThread.h and SkThreadPriv.h all get ...
6 years, 6 months ago (2014-05-28 19:10:20 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-05-28 19:27:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/305753002/70001
6 years, 6 months ago (2014-05-28 19:27:26 UTC) #5
commit-bot: I haz the power
Change committed as 14929
6 years, 6 months ago (2014-05-28 19:40:33 UTC) #6
mtklein
A revert of this CL has been created in https://codereview.chromium.org/300843012/ by mtklein@google.com. The reason for ...
6 years, 6 months ago (2014-05-28 19:57:48 UTC) #7
mtklein
On 2014/05/28 19:57:48, mtklein wrote: > A revert of this CL has been created in ...
6 years, 6 months ago (2014-05-28 20:14:09 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-05-28 21:03:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/305753002/90001
6 years, 6 months ago (2014-05-28 21:03:19 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 21:44:02 UTC) #11
Message was sent while issue was closed.
Change committed as 14938

Powered by Google App Engine
This is Rietveld 408576698