content/browser/service_worker/service_worker_register_job.cc - Issue 305723003: Shut down the ServiceWorker system as the browser's shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 305723003: Shut down the ServiceWorker system as the browser's shutting down. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove a redundant clear() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 946a90ed6010db306d74fd396d73171b8259d95e..b81422d8d91f001a5da80c644dee8934b8be3cf8 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -38,7 +38,8 @@ ServiceWorkerRegisterJob::ServiceWorkerRegisterJob(

weak_factory_(this) {}

ServiceWorkerRegisterJob::~ServiceWorkerRegisterJob() {

- DCHECK(phase_ == INITIAL || phase_ == COMPLETE);

+ DCHECK(!context_ || phase_ == INITIAL || phase_ == COMPLETE)

+ << "Jobs should only be interrupted during shutdown.";

}

void ServiceWorkerRegisterJob::AddCallback(const RegistrationCallback& callback,