Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: Source/modules/InitModules.cpp

Issue 305723002: Use method registration approach for creating events on core and modules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix oilpan compilation. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/InitModules.cpp
diff --git a/Source/modules/InitModules.cpp b/Source/modules/InitModules.cpp
index d0e8b903aece57d655baf0d9f44347c09df8a86f..0752e927df317b4396b084c86fdc8ac94cbac891 100644
--- a/Source/modules/InitModules.cpp
+++ b/Source/modules/InitModules.cpp
@@ -25,13 +25,10 @@ void ModulesInitializer::initEventTargetNames()
EventTargetNames::initModules();
}
-PassRefPtrWillBeRawPtr<Event> createEventModules(const String& eventType, ExceptionState& exceptionState)
+void ModulesInitializer::registerEventFactory()
{
- RefPtrWillBeRawPtr<Event> event = EventModulesFactory::create(eventType);
- if (event)
- return event.release();
-
- return Document::createEvent(eventType, exceptionState);
+ CoreInitializer::registerEventFactory();
+ Document::registerEventFactory(new EventModulesFactory());
eseidel 2014/05/28 22:04:23 create() functions are generally nicer than new, c
c.shu 2014/05/29 15:06:49 Ok. thanks.
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698