Source/modules/EventModulesFactory.h - Issue 305723002: Use method registration approach for creating events on core and modules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/EventModulesFactory.h

Issue 305723002: Use method registration approach for creating events on core and modules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix oilpan compilation. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EventModulesFactory_h	5 #ifndef EventModulesFactory_h

6 #define EventModulesFactory_h	6 #define EventModulesFactory_h

7	7

	8 #include "core/events/EventFactory.h"

8 #include "platform/heap/Handle.h"	9 #include "platform/heap/Handle.h"

9 #include "wtf/PassRefPtr.h"	10 #include "wtf/PassRefPtr.h"

10 #include "wtf/text/AtomicString.h"	11 #include "wtf/text/AtomicString.h"

11	12

12 namespace WebCore {	13 namespace WebCore {

13	14

14 class Event;	15 class Event;

15	16

16 class EventModulesFactory {	17 class EventModulesFactory : public EventFactoryBase {

17 public:	18 public:

18 static PassRefPtrWillBeRawPtr<Event> create(const String& eventType);	19 virtual PassRefPtrWillBeRawPtr<Event> create(const String& eventType) OVERRI DE;
	eseidel 2014/05/28 22:04:23 Surprised this isn't an AtomicString. I guess we Surprised this isn't an AtomicString. I guess we create events on non-main threads? c.shu 2014/05/29 15:06:49 Not sure. Maybe worth investigation. Show quoted text On 2014/05/28 22:04:23, eseidel wrote: > Surprised this isn't an AtomicString. I guess we create events on non-main > threads? Not sure. Maybe worth investigation.
19 };	20 };

20	21

21 }	22 }

22	23

23 #endif	24 #endif

OLD	NEW

« no previous file with comments | « Source/core/events/EventFactory.h ('k') | Source/modules/InitModules.h » ('j') | Source/modules/InitModules.cpp » ('J')