Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 305663002: Adds hashes for metricsPrivate permissions for CRU. (Closed)

Created:
6 years, 7 months ago by Drew Haven
Modified:
6 years, 6 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds hashes for the Chromebook Recovery Utility to the metricsPrivate permissions. This is so we can check if the user has opted into stats before enabling initializing analytics in our app. BUG=378067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Drew Haven
Mike, Could you quickly review this API permissions change for me? We want to add ...
6 years, 7 months ago (2014-05-27 23:54:44 UTC) #1
miket_OOO
lgtm
6 years, 6 months ago (2014-06-02 15:11:37 UTC) #2
Drew Haven
The CQ bit was checked by haven@chromium.org
6 years, 6 months ago (2014-06-02 17:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/305663002/1
6 years, 6 months ago (2014-06-02 17:41:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:13:56 UTC) #5
Message was sent while issue was closed.
Change committed as 274329

Powered by Google App Engine
This is Rietveld 408576698