Issue 305653008: Escape more characters for GN shell writing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305653008: Escape more characters for GN shell writing. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Escape more characters for GN shell writing. BUG=358764 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273857

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -8 lines)			Patch
	M	tools/gn/escape.cc	View		3 chunks	+28 lines, -6 lines	2 comments	Download
	M	tools/gn/escape_unittest.cc	View		1 chunk	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #1 manually as r273857 (presubmit successful).

6 years, 6 months ago (2014-05-30 16:29:19 UTC) #2

scottmg

6 years, 6 months ago (2014-05-30 18:02:15 UTC) #3

Message was sent while issue was closed.

sorry for the delay

https://codereview.chromium.org/305653008/diff/1/tools/gn/escape.cc
File tools/gn/escape.cc (right):

https://codereview.chromium.org/305653008/diff/1/tools/gn/escape.cc#newcode39
tools/gn/escape.cc:39: // escaping for the shell, we need to backslash-escape
that again.
this should be if !WIN i think

https://codereview.chromium.org/305653008/diff/1/tools/gn/escape.cc#newcode80
tools/gn/escape.cc:80: } else if ((options.mode & ESCAPE_SHELL) &&
and this too, or at least \ doesn't escape them on windows. or is ESCAPE_SHELL
not used on windows? in that case, i'd rename "shell" in various places to
POSIX_SHELL or BASH or something.

Expand Messages | Collapse Messages