Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 305643006: Enable a srcset 0x descriptor (Closed)

Created:
6 years, 6 months ago by Yoav Weiss
Modified:
6 years, 6 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable a srcset 0x descriptor According to recent spec changes, a "0x" descriptor should be correctly parsed, and imply intrinsic dimensions of infinity to the image. This CL enables that, and tests that intrinsic dimensions are impacted accordingly. BUG=378252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175196 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175360

Patch Set 1 #

Patch Set 2 : Fix a float truncation bug #

Patch Set 3 : Split the zero size test and skip it on windows #

Patch Set 4 : Fix TestExpectations #

Patch Set 5 : TestExpectations take 3 #

Patch Set 6 : Added debug and gpu to TestExpectations #

Patch Set 7 : Rebase and unflake the layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
A LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html View 1 2 3 4 5 6 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero-expected.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
Yoav Weiss
6 years, 6 months ago (2014-05-28 12:12:43 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-05-28 22:27:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/1
6 years, 6 months ago (2014-05-28 22:27:55 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-28 23:57:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 01:01:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9562)
6 years, 6 months ago (2014-05-29 01:01:59 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-05-29 01:15:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/1
6 years, 6 months ago (2014-05-29 01:16:10 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-29 02:23:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 03:14:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9572)
6 years, 6 months ago (2014-05-29 03:14:25 UTC) #11
Yoav Weiss
On 2014/05/29 03:14:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-05-29 04:36:05 UTC) #12
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 09:05:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/20001
6 years, 6 months ago (2014-05-30 09:06:31 UTC) #14
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 09:09:39 UTC) #15
Yoav Weiss
I've fixed a freshly committed, related bug. (float was clamped to an int) I've also ...
6 years, 6 months ago (2014-05-30 15:20:11 UTC) #16
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 15:44:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/40001
6 years, 6 months ago (2014-05-30 15:45:39 UTC) #18
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 16:17:24 UTC) #19
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-31 05:00:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/80001
6 years, 6 months ago (2014-05-31 05:00:53 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-31 06:46:04 UTC) #22
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 6 months ago (2014-05-31 07:13:07 UTC) #23
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-31 08:41:35 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/100001
6 years, 6 months ago (2014-05-31 08:41:43 UTC) #25
commit-bot: I haz the power
Change committed as 175196
6 years, 6 months ago (2014-05-31 09:52:17 UTC) #26
Yoav Weiss
A revert of this CL has been created in https://codereview.chromium.org/302083009/ by yoav@yoav.ws. The reason for ...
6 years, 6 months ago (2014-05-31 10:55:38 UTC) #27
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-06-03 10:59:28 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/305643006/120001
6 years, 6 months ago (2014-06-03 10:59:56 UTC) #29
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-03 11:15:59 UTC) #30
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:32:50 UTC) #31
Message was sent while issue was closed.
Change committed as 175360

Powered by Google App Engine
This is Rietveld 408576698