Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 305633005: Revert of Content side of languagechange event fired on accept languages changes. (Closed)

Created:
6 years, 7 months ago by tkent
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Content side of languagechange event fired on accept languages changes. (https://codereview.chromium.org/280953002/) Reason for revert: Broke two layout tests: fast/forms/validationMessage.html and fast/forms/email-idn-conversion.html Original issue's description: > Content side of languagechange event fired on accept languages changes. > > This call the WebView API to notify the pages that the accept languages > has changed and setup the test runner to allow Blink to change the > accept languages for test purposes. > > Depends on https://codereview.chromium.org/284793003/ > > BUG=365123 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273076 BUG=378129 NOTRY=true TBR=mlamouri@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 4 chunks +0 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tkent
Created Revert of Content side of languagechange event fired on accept languages changes.
6 years, 7 months ago (2014-05-28 03:08:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/305633005/1
6 years, 7 months ago (2014-05-28 03:10:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 03:10:31 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-28 03:10:32 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-28 03:12:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/305633005/1
6 years, 7 months ago (2014-05-28 03:12:52 UTC) #6
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 7 months ago (2014-05-28 03:21:23 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-28 03:21:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/305633005/1
6 years, 7 months ago (2014-05-28 03:22:15 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 03:24:01 UTC) #10
Message was sent while issue was closed.
Change committed as 273144

Powered by Google App Engine
This is Rietveld 408576698