Puts notification buttons back below the image

Puts notification buttons back below the image

A regression caused buttons to be rendered above the image.  This fixes
the problem by forcing the image to be the first child of the bottom
view (image is together with the buttons in the bottom view).

BUG=378077, 368025
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274353

[robliao, 2014-05-28 17:55:48]

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:310:
notification_view()->CreateOrUpdateViews(*notification());
Seems like we're repeating what we just tested. What changes here?

[dewittj, 2014-05-28 18:59:04]

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:310:
notification_view()->CreateOrUpdateViews(*notification());
On 2014/05/28 17:55:48, robliao wrote:
> Seems like we're repeating what we just tested. What changes here?

The bug only repros when createorupdateviews is called more than once, since the
image view was added to the end of the children of the bottom view, but the
buttons were reused causing the image to appear at the bottom.

[robliao, 2014-05-28 19:29:04]

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:310:
notification_view()->CreateOrUpdateViews(*notification());
Let's put a note about that here before this gets optimized away.

On 2014/05/28 18:59:04, dewittj wrote:
> On 2014/05/28 17:55:48, robliao wrote:
> > Seems like we're repeating what we just tested. What changes here?
> 
> The bug only repros when createorupdateviews is called more than once, since
the
> image view was added to the end of the children of the bottom view, but the
> buttons were reused causing the image to appear at the bottom.

[dewittj, 2014-05-30 00:44:36]

improved the organization a little bit too.

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:310:
notification_view()->CreateOrUpdateViews(*notification());
On 2014/05/28 19:29:05, robliao wrote:
> Let's put a note about that here before this gets optimized away.
> 
> On 2014/05/28 18:59:04, dewittj wrote:
> > On 2014/05/28 17:55:48, robliao wrote:
> > > Seems like we're repeating what we just tested. What changes here?
> > 
> > The bug only repros when createorupdateviews is called more than once, since
> the
> > image view was added to the end of the children of the bottom view, but the
> > buttons were reused causing the image to appear at the bottom.
> 

Done.

[robliao, 2014-05-30 01:19:33]

lgtm!

https://codereview.chromium.org/305633004/diff/40001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/40001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:83: gfx::Point
current_point = (*current)->bounds().origin();
This was CenterPoint before. Is origin a better measure? I would expect the
result to be the same either way.

[dewittj, 2014-06-02 18:00:05]

https://codereview.chromium.org/305633004/diff/40001/ui/message_center/views/...
File ui/message_center/views/notification_view_unittest.cc (right):

https://codereview.chromium.org/305633004/diff/40001/ui/message_center/views/...
ui/message_center/views/notification_view_unittest.cc:83: gfx::Point
current_point = (*current)->bounds().origin();
On 2014/05/30 01:19:33, robliao wrote:
> This was CenterPoint before. Is origin a better measure? I would expect the
> result to be the same either way.

It was easier for me to verify that they were in roughly the right spot while
logging, and seemed equivalent so I left it as origin()

[dewittj, 2014-06-02 18:20:54]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-06-02 18:22:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/305633004/40001

[commit-bot: I haz the power, 2014-06-02 22:25:41]

Change committed as 274353