Issue 305623007: Add aggregated stats to selected trace event details

Issue 305623007: Add aggregated stats to selected trace event details (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add aggregated stats to selected trace event details BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174993

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	1	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm https://codereview.chromium.org/305623007/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/305623007/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode910 Source/devtools/front_end/timeline/TimelineUIUtils.js:910: for (;index < events.length; index++) { missing space

6 years, 6 months ago (2014-05-28 18:43:14 UTC) #2

yurys

https://codereview.chromium.org/305623007/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/305623007/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode910 Source/devtools/front_end/timeline/TimelineUIUtils.js:910: for (;index < events.length; index++) { On 2014/05/28 18:43:14, ...

6 years, 6 months ago (2014-05-28 19:18:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/305623007/20001

6 years, 6 months ago (2014-05-28 19:19:10 UTC) #5

Message was sent while issue was closed.

Change committed as 174993

Expand Messages | Collapse Messages