Issue 305623004: Calculate non client hittest values by converting the corresponding system metrics returned via the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 305623004: Calculate non client hittest values by converting the corresponding system metrics returned via the… (Closed)

Created:
6 years, 7 months ago by ananta

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Calculate non client hittest values by converting the corresponding system metrics returned via the GetSystemMetrics API on Windows to DIP. The API returns pixel values which are compared against points in DIP which gives wrong non client hittest values. The bug only happens on glass. BUG=377983 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273124

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/frame/glass_browser_frame_view.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/305623004/1

6 years, 7 months ago (2014-05-27 22:58:21 UTC) #4

Message was sent while issue was closed.

Change committed as 273124

Expand Messages | Collapse Messages