chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc - Issue 3056029: Move the number conversions from string_util to a new file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc

===================================================================

--- chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc (revision 54340)

+++ chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc (working copy)

@@ -10,7 +10,8 @@

#include "base/callback.h"

#include "base/logging.h"

#include "base/rand_util.h"

-#include "base/string_util.h"

+#include "base/string_number_conversions.h"

+//#include "base/string_util.h"

#include "chrome/browser/sync/sync_constants.h"

#include "google/cacheinvalidation/invalidation-client.h"

#include "jingle/notifier/listener/xml_element_util.h"

@@ -170,7 +171,7 @@

buzz::XmlElement* cache_invalidation_iq_packet =

new buzz::XmlElement(kQnData, true);

iq->AddElement(cache_invalidation_iq_packet);

- cache_invalidation_iq_packet->SetAttr(kQnSeq, IntToString(seq));

+ cache_invalidation_iq_packet->SetAttr(kQnSeq, base::IntToString(seq));

cache_invalidation_iq_packet->SetAttr(kQnSid, sid);

cache_invalidation_iq_packet->SetAttr(kQnServiceUrl,

browser_sync::kSyncServiceUrl);

@@ -188,7 +189,7 @@

std::string MakeSid() {

uint64 sid = base::RandUint64();

- return std::string("chrome-sync-") + Uint64ToString(sid);

+ return std::string("chrome-sync-") + base::Uint64ToString(sid);

}

} // namespace

Property changes on: chrome\browser\sync\notifier\cache_invalidation_packet_handler.cc

___________________________________________________________________

Added: svn:eol-style

+ LF