chrome/browser/cocoa/about_window_controller.mm - Issue 3056029: Move the number conversions from string_util to a new file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/about_window_controller.mm

Issue 3056029: Move the number conversions from string_util to a new file.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/about_window_controller.mm

===================================================================

--- chrome/browser/cocoa/about_window_controller.mm (revision 54340)

+++ chrome/browser/cocoa/about_window_controller.mm (working copy)

@@ -8,6 +8,7 @@

#include "app/resource_bundle.h"

#include "base/logging.h"

#include "base/mac_util.h"

+#include "base/string_number_conversions.h"

#include "base/string_util.h"

#include "base/sys_string_conversions.h"

#include "chrome/browser/browser_list.h"

@@ -452,7 +453,7 @@

// just to get the throbber to stop spinning if it's running.

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

break;

@@ -550,14 +551,14 @@

// just to get the throbber to stop spinning if it's running.

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

break;

case kAutoupdateRegisterFailed:

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

enablePromoteButton = false;

break;

@@ -565,7 +566,7 @@

case kAutoupdateCheckFailed:

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

break;

@@ -574,7 +575,7 @@

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

// Allow another chance.

enableUpdateButton = true;

@@ -586,7 +587,7 @@

imageID = IDR_UPDATE_FAIL;

message = l10n_util::GetNSStringFWithFixup(IDS_UPGRADE_ERROR,

- IntToString16(status));

+ base::IntToString16(status));

break;

« no previous file with comments | « chrome/browser/chromeos/update_observer.cc ('k') | chrome/browser/cocoa/history_menu_bridge.mm » ('j') | no next file with comments »