Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 305563002: MIPS: Use TempDoubleRegister. (Closed)

Created:
6 years, 6 months ago by kilvadyb
Modified:
6 years, 6 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Use TempDoubleRegister. Port r21517 (53d6507) BUG=

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/mips/lithium-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 6 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kilvadyb
6 years, 6 months ago (2014-05-27 11:31:24 UTC) #1
Paul Lind
https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc#newcode1159 src/mips/lithium-mips.cc:1159: LOperand* temp = FixedTemp(f6); please remove this one, also. ...
6 years, 6 months ago (2014-05-27 13:56:22 UTC) #2
kilvadyb
https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc#newcode1159 src/mips/lithium-mips.cc:1159: LOperand* temp = FixedTemp(f6); On 2014/05/27 13:56:22, Paul Lind ...
6 years, 6 months ago (2014-05-27 15:59:16 UTC) #3
Paul Lind
lgtm
6 years, 6 months ago (2014-05-27 17:04:38 UTC) #4
Paul Lind
6 years, 6 months ago (2014-05-27 17:07:19 UTC) #5 
Committed as r21537.

Powered by Google App Engine
This is Rietveld 408576698